Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@charliepark @david-crespo Ready for your perusal! |
|
The arrow being on the right instead of the left is a little silly — maybe it doesn't need an arrow? Or maybe there's a more directionally neutral indicator? 
|
|
The light badge feels either too low-contrast or the background is just too bright — it stands out in a way that feels meaningful but isn't. The contrast is not so bad it violates a11y rules, but it's just barely over the 4.5 line for AA. 
|
The Base UI migration put z-index on Menu.Popup, a child of the positioned Menu.Positioner. Since the positioner had no z-index, it sat at auto in the stacking context, below the sticky pagination bar (z-index 15). Row action dropdowns near the bottom of a table were unclickable because the pagination intercepted pointer events.
|
17bee1f fixes the failing e2e by fixing this. 
|
|
Overall I LOVE the new colors. It's a subtle change but it feels fantastic. Preview banner feels a little saturated, but maybe I'm just not used to it. 
The text in the first two columns feels too light — it doesn't feel like there's a reason for it to be lighter than the links. Maybe it's that darkening is not usually what you do for emphasizing a link. I feel like you're more likely to see it lightened (or tinted of course). The contrast between the table header and the background is also kind of low, feels a little muddy. 
|
david-crespo
force-pushed
the
light-mode
branch
from
16ed29c to
3e25db0
Compare
|
I thought we had introduced a problem with the color of the loading bar, but it turns out that we actually already had a pretty big problem with the color of the loading bar, and I just didn't realize because my Firefox has dark UI chrome. The loading bar is only visible properly when both the chrome and the page theme match. When one is dark and the other is light, the loading bar is lost visually somehow in boundary. 2026-02-23-loading-bar-light-chrome.mp42026-02-23-loading-bar-dark-chrome.mp4 |
|
Wonderful, will get to the polish issues in due course |
2 participants
Bump
@oxide/design-systemto v5 and add light mode support.Including:
localStoragedata-themeattribute applied to the document root viauseApplyThemefor theme supportindex.htmlscript to set theme before first paint to prevent flashlight:overrides (tabs, buttons, checkboxes, radios, dropdowns, etc.)